Written on Jul 11, 2018
Sent out a bunch of patches with changes made according to the review comments.
Trying to figure out how
arc diff works.
Suppose you have the following commits (latest first)
AAA - Bug AAA BBB - Bug BBB CCC - Bug CCC
and you want to submit only commit B for the review.
You need to
$ arc diff HEAD^to submit the review
If you want to preview what you are about to submit you can do
$ arc diff --preview HEAD^
git cinnabar fetch hg::https://hg.mozilla.org/try <changeset>
git config core.ignorecase true
git rebase FETCH_HEAD
Realized that browser_noopener* tests were hanging because they expected a new window to be created, but the bug fix was to make it so a new tab would open instead. So I modified the tests and now the tests pass. Success!